Add Inline code action to Retrie plugin #3444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
requested review from
isovector,
santiweight,
OliverMadine and
July541
as code owners
pepeiborra
force-pushed
the
retrie-inline
branch
from
69c8ac3 to
b8ea91f
Compare
|
This is ready for review: a look of @fendor at the test suite changes should be all is needed |
fendor
approved these changes
Jan 29, 2023
wz1000
pushed a commit
that referenced
this pull request
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new code action to hls-retrie-plugin that allows to inline a definition "on the spot". There are some caveats:
Another addition is a test suite for the plugin. Since hls-retrie-plugin depends on hls-refactor-plugin, the test suite needs to tell
goldenWithHaskellDocto run both plugins. I had to refactor a few things in order to make this possible, hence the large changeset.Screen.Recording.2023-01-07.at.20.08.49.mov